Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable import/no-unresolved rule for commonjs #25

Merged
merged 3 commits into from
Oct 22, 2024
Merged

chore: enable import/no-unresolved rule for commonjs #25

merged 3 commits into from
Oct 22, 2024

Conversation

donotlb
Copy link
Contributor

@donotlb donotlb commented Oct 22, 2024

相关: https://github.com/blocklet/discuss-kit/issues/3084

examples/react/src/index.js 中测试 require 一个不存在的模块, 符合预期 (调整前没有 eslint error)

image

@donotlb donotlb marked this pull request as draft October 22, 2024 03:59
@donotlb donotlb marked this pull request as ready for review October 22, 2024 06:19
@donotlb donotlb merged commit 067cf40 into main Oct 22, 2024
3 checks passed
@donotlb donotlb deleted the no-unresolved-commonjs branch October 22, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LancelotLewis LancelotLewis LancelotLewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donotlb @LancelotLewis